Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #59
This fix is pretty limited though. A better fix would evaluate the values. For this 1. need to stop using desc to look up the sub-command, 2. don't store the desc for sub-commands, 3. get the desc at runtime (similar to applySetter; but get instead of set). Alternatively, maybe just populate desc field at runtime.
In Nim 1.6 genEnumCaseStmt errors out. It could be fixed by generating an enum case of elements instead of values; it currently sets the enum by value desc if present (which is a bit iffy).